linux-kernel - Re: [PATCH V3] crypto: qcom-rng - Add hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230925225700.GC437346@hu-bjorande-lv.qualcomm.com>
Date:   Mon, 25 Sep 2023 15:57:00 -0700
From:   Bjorn Andersson <quic_bjorande@...cinc.com>
To:     Om Prakash Singh <quic_omprsing@...cinc.com>
CC:     <neil.armstrong@...aro.org>, <konrad.dybcio@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>, <conor+dt@...nel.org>,
        <davem@...emloft.net>, <devicetree@...r.kernel.org>,
        <herbert@...dor.apana.org.au>, <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <marijn.suijten@...ainline.org>,
        <robh+dt@...nel.org>, <vkoul@...nel.org>
Subject: Re: [PATCH V3] crypto: qcom-rng - Add hw_random interface support

On Mon, Sep 25, 2023 at 10:53:12PM +0530, Om Prakash Singh wrote:
> From: Om Prakash Singh <omprsing@....qualcomm.com>

That is not a valid email address here, please correct this.

> 
> Add hw_random interface support in qcom-rng driver as new IP block
> in Qualcomm SoC has inbuilt NIST SP800 90B compliant entropic source
> to generate true random number.
> 
> Keeping current rng_alg interface as well for random number generation
> using Kernel Crypto API.
> 
> Signed-off-by: Om Prakash Singh <quic_omprsing@...cinc.com>
[..]
> diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
[..]
> +static int qcom_hwrng_read(struct hwrng *hwrng, void *data, size_t max, bool wait)
> +{
> +	struct qcom_rng *qrng =  container_of(hwrng, struct qcom_rng, hwrng);

Please also remove one of the spaces after '='.


Other than that, this looks good to me.

Regards,
Bjorn