linux-kernel - Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPM=9twSNbXEttteT=NBqn3baxVPHcSHfJ-aUmneKuhO4yDiEg@mail.gmail.com>
Date:   Mon, 25 Sep 2023 10:41:18 +1000
From:   Dave Airlie <airlied@...il.com>
To:     Sarah Walker <sarah.walker@...tec.com>
Cc:     dri-devel@...ts.freedesktop.org, frank.binns@...tec.com,
        donald.robson@...tec.com, boris.brezillon@...labora.com,
        daniel@...ll.ch, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, corbet@....net, christian.koenig@....com,
        linus.walleij@...aro.org, matt.coster@...tec.com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-doc@...r.kernel.org, faith.ekstrand@...labora.com,
        afd@...com, hns@...delico.com, matthew.brost@...el.com,
        luben.tuikov@....com, dakr@...hat.com
Subject: Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

> +struct drm_pvr_dev_query_gpu_info {
> +       /**
> +        * @gpu_id: GPU identifier.
> +        *
> +        * For all currently supported GPUs this is the BVNC encoded as a 64-bit
> +        * value as follows:
> +        *
> +        *    +--------+--------+--------+-------+
> +        *    | 63..48 | 47..32 | 31..16 | 15..0 |
> +        *    +========+========+========+=======+
> +        *    | B      | V      | N      | C     |
> +        *    +--------+--------+--------+-------+
> +        */
> +       __u64 gpu_id;
> +
> +       /**
> +        * @num_phantoms: Number of Phantoms present.
> +        */
> +       __u32 num_phantoms;
> +};

I think this one needs __u32 padding; of some sort.

Dave.