linux-kernel - Re: [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQf6YVF6yCi3tRHE9Rf0o3g2MLqfiLxyJg4-fiM6ZmBZQ@mail.gmail.com>
Date:   Mon, 25 Sep 2023 16:05:35 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Martin Nybo Andersen <tweek@...ek.dk>
Cc:     Tor Vic <torvic9@...lbox.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Nick Terrell <terrelln@...com>, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Lucas De Marchi <lucas.de.marchi@...il.com>
Subject: Re: [PATCH] Use CRC32 and a 1MiB dictionary for XZ compressed modules

On Fri, Sep 22, 2023 at 10:34 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Fri, Sep 22, 2023 at 8:04 PM Martin Nybo Andersen <tweek@...ek.dk> wrote:
> >
> >
> > On Fri, 22 Sep 2023, Masahiro Yamada wrote:
> >
> > [...]
> >
> > > Hello, sorry for the delay.
> > >
> > > I am OK with picking the patch to my tree.
> >
> > Hi,
> >
> > That sound great :)
> >
> > > I think we can use --check=crc32 --lzma2=dict=1MiB
> > > unconditionally.
> > >
> > > (But, if the in-kernel decompressor is improved
> > > to understand CRC64 in the future, we can loosen
> > > this restriction again.)
> >
> > Of course.
> >
> > > Just small change requests.
> > >
> > > Please do not use the Fixes tag to point at the Debian bug tracker.
> > >
> > >
> > > Instead, you can do
> > >
> > > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050582
> > >
> > >   or
> > >
> > > Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050582
> > >
> > >
> > >
> > > Also, mention that this change happened in
> > >
> > > kmod commit 09c9f8c5df04 ("libkmod: Use kernel decompression when available")
> > >
> > > in the commit description might be helpful.
> > >
> > >
> > >
> > >
> > > I added Lukas to CC.
> > > He is the author of the change on kmod side.
> >
> > Is this ok?
>
>
> Yes, perfect!
>
> Thanks.
>


Applied to linux-kbuild. Thanks.




-- 
Best Regards
Masahiro Yamada