linux-kernel - Re: [PATCH] ata: libata: increase PMP SRST timeout to 10s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b55b0ec2-7afe-3c63-64b7-ae748db8b7ec@kernel.org>
Date:   Mon, 25 Sep 2023 09:12:09 +0200
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Matthias Schiffer <mschiffer@...verse-factory.net>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: libata: increase PMP SRST timeout to 10s

On 2023/09/22 22:55, Matthias Schiffer wrote:
> On certain SATA controllers, softreset fails after wakeup from S2RAM with
> the message "softreset failed (1st FIS failed)", sometimes resulting in
> drives not being detected again. With the increased timeout, this issue
> is avoided. Instead, "softreset failed (device not ready)" is now
> logged 1-2 times; this later failure seems to cause fewer problems
> however, and the drives are detected reliably once they've spun up and
> the probe is retried.
> 
> The issue was observed with the primary SATA controller of the QNAP
> TS-453B, which is an "Intel Corporation Celeron/Pentium Silver Processor
> SATA Controller [8086:31e3] (rev 06)" integrated in the Celeron J4125 CPU,
> and the following drives:
> 
> - Seagate IronWolf ST12000VN0008
> - Seagate IronWolf ST8000NE0004
> 
> The SATA controller seems to be more relevant to this issue than the
> drives, as the same drives are always detected reliably on the secondary
> SATA controller on the same board (an ASMedia 106x) without any "softreset
> failed" errors even without the increased timeout.
> 
> Fixes: e7d3ef13d52a ("libata: change drive ready wait after hard reset to 5s")
> Signed-off-by: Matthias Schiffer <mschiffer@...verse-factory.net>

Applied to for-6.6-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research