[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230925-confined-tibia-9982d3267806@wendy>
Date: Mon, 25 Sep 2023 11:20:39 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
CC: Daire McNamara <daire.mcnamara@...rochip.com>,
<linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<kernel@...gutronix.de>
Subject: Re: [PATCH 16/40] soc/microchip: mpfs-sys-controller: Convert to
platform remove callback returning void
On Mon, Sep 25, 2023 at 11:55:07AM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Applied with some cosmetic changes to the commit message, thanks!
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists