linux-kernel - Re: [PATCH 1/2] fs/ceph/debugfs: make all files world-readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd19d9585b29952fcd727c1a6c47289f66ab96b7.camel@kernel.org>
Date:   Mon, 25 Sep 2023 07:29:43 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Ilya Dryomov <idryomov@...il.com>,
        Max Kellermann <max.kellermann@...os.com>
Cc:     Xiubo Li <xiubli@...hat.com>, ceph-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lorenzo Bianconi <lorenzo@...nel.org>
Subject: Re: [PATCH 1/2] fs/ceph/debugfs: make all files world-readable

On Mon, 2023-09-25 at 12:41 +0200, Ilya Dryomov wrote:
> On Fri, Sep 22, 2023 at 8:26 AM Max Kellermann <max.kellermann@...os.com> wrote:
> > 
> > I'd like to be able to run metrics collector processes without special
> > privileges
> 
> Hi Max,
> 
> A word of caution about building metrics collectors based on debugfs
> output: there are no stability guarantees.  While the format won't be
> changed just for the sake of change of course, expect zero effort to
> preserve backwards compatibility.
> 
> The latency metrics in particular are sent to the MDS in binary form
> and are intended to be consumed through commands like "ceph fs top".
> debugfs stuff is there just for an occasional sneak peek (apart from
> actual debugging).
> 

FWIW, I wish we had gone with netlink for this functionality instead of
a seqfile. Lorenzo has been working with netlink for some similar
functionality with nfsd[1], and it's much nicer for this sort of thing.

[1]: https://lore.kernel.org/linux-nfs/ZQTM6l7NrsVHFoR5@lore-desk/T/#t

-- 
Jeff Layton <jlayton@...nel.org>