| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <df8ac3ef-6103-4499-a52e-d0f4fdfbad05@kernel.org>
Date: Tue, 26 Sep 2023 21:46:32 +0300
From: Roger Quadros <rogerq@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
Peter Ujfalusi <peter.ujfalusi@...il.com>
Cc: Vinod Koul <vkoul@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Siddharth Vadapalli <s-vadapalli@...com>,
Grygorii Strashko <grygorii.strashko@...com>,
MD Danish Anwar <danishanwar@...com>,
Andrew Lunn <andrew@...n.ch>,
Vignesh Raghavendra <vigneshr@...com>,
dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 3/3 net] dmaengine: ti: k3-udma-glue: clean up
k3_udma_glue_tx_get_irq() return
On 26/09/2023 17:06, Dan Carpenter wrote:
> The k3_udma_glue_tx_get_irq() function currently returns negative error
> codes on error, zero on error and positive values for success. This
> complicates life for the callers who need to propagate the error code.
> Also GCC will not warn about unsigned comparisons when you check:
>
> if (unsigned_irq <= 0)
>
> All the callers have been fixed now but let's just make this easy going
> forward.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
Reviewed-by: Roger Quadros <rogerq@...nel.org>
Powered by blists - more mailing lists