linux-kernel - RE: [RFC PATCH 09/25] perf stat: Add helper functions for hardware-grouping method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO6PR11MB5635456DB6A4CDED3697E3A0EEC3A@CO6PR11MB5635.namprd11.prod.outlook.com>
Date:   Tue, 26 Sep 2023 20:51:09 +0000
From:   "Wang, Weilin" <weilin.wang@...el.com>
To:     Yang Jihong <yangjihong1@...wei.com>,
        Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        "Namhyung Kim" <namhyung@...nel.org>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        "Kan Liang" <kan.liang@...ux.intel.com>
CC:     "linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Taylor, Perry" <perry.taylor@...el.com>,
        "Alt, Samantha" <samantha.alt@...el.com>,
        "Biggers, Caleb" <caleb.biggers@...el.com>,
        Mark Rutland <mark.rutland@....com>
Subject: RE: [RFC PATCH 09/25] perf stat: Add helper functions for
 hardware-grouping method



> -----Original Message-----
> From: Yang Jihong <yangjihong1@...wei.com>
> Sent: Monday, September 25, 2023 8:37 PM
> To: Wang, Weilin <weilin.wang@...el.com>; Ian Rogers
> <irogers@...gle.com>; Peter Zijlstra <peterz@...radead.org>; Ingo Molnar
> <mingo@...hat.com>; Arnaldo Carvalho de Melo <acme@...nel.org>;
> Alexander Shishkin <alexander.shishkin@...ux.intel.com>; Jiri Olsa
> <jolsa@...nel.org>; Namhyung Kim <namhyung@...nel.org>; Hunter, Adrian
> <adrian.hunter@...el.com>; Kan Liang <kan.liang@...ux.intel.com>
> Cc: linux-perf-users@...r.kernel.org; linux-kernel@...r.kernel.org; Taylor,
> Perry <perry.taylor@...el.com>; Alt, Samantha <samantha.alt@...el.com>;
> Biggers, Caleb <caleb.biggers@...el.com>; Mark Rutland
> <mark.rutland@....com>
> Subject: Re: [RFC PATCH 09/25] perf stat: Add helper functions for hardware-
> grouping method
> 
> Hello,
> 
> On 2023/9/25 14:18, weilin.wang@...el.com wrote:
> > From: Weilin Wang <weilin.wang@...el.com>
> >
> > Add functions to free pmu_info_list and event_info_list before exit
> > grouping
> >
> > Signed-off-by: Weilin Wang <weilin.wang@...el.com>
> > ---
> >   tools/perf/util/metricgroup.c | 32 ++++++++++++++++++++++++++++----
> >   1 file changed, 28 insertions(+), 4 deletions(-)
> >
> > diff --git a/tools/perf/util/metricgroup.c
> > b/tools/perf/util/metricgroup.c index feb5dab26..0ca885a42 100644
> > --- a/tools/perf/util/metricgroup.c
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -1507,6 +1507,27 @@ static int parse_counter(const char *counter,
> >   	return 0;
> >   }
> >
> > +static void metricgroup__free_event_info(struct list_head
> > +					*event_info_list)
> > +{
> > +	struct metricgroup__event_info *e, *tmp;
> > +
> > +	list_for_each_entry_safe(e, tmp, event_info_list, nd) {
> > +		list_del_init(&e->nd);
> > +		free(e);
> > +	}
> > +}
> > +
> > +static void metricgroup__free_pmu_info(struct list_head
> > +*pmu_info_list) {
> > +	struct metricgroup__pmu_counters *p, *tmp;
> > +
> > +	list_for_each_entry_safe(p, tmp, pmu_info_list, nd) {
> > +		list_del_init(&p->nd);
> > +		free(p);
> > +	}
> > +}
> > +
> >   static struct metricgroup__event_info *event_info__new(const char *name,
> >   						      const char *pmu_name,
> >   						      const char *counter,
> > @@ -1524,7 +1545,8 @@ static struct metricgroup__event_info
> *event_info__new(const char *name,
> >   	}
> >   	e->name = name;
> >   	e->free_counter = free_counter;
> > -	e->pmu_name = strdup(pmu_name);
> > +	//e->pmu_name = strdup(pmu_name);
> Can the commented-out code be deleted?
> 
> > +	e->pmu_name = pmu_name;
> >   	if (free_counter) {
> >   		ret = set_counter_bitmap(0, e->counters);
> >   		if (ret)
> > @@ -1687,13 +1709,15 @@ static int hw_aware_build_grouping(struct
> > expr_parse_ctx *ctx __maybe_unused,
> >
> >   		ret = get_metricgroup_events(id, etable, &event_info_list);
> >   		if (ret)
> > -			return ret;
> > +			goto err_out;
> >   	}
> >   	ret = get_pmu_counter_layouts(&pmu_info_list, ltable);
> >   	if (ret)
> > -		return ret;
> > -
> > +		goto err_out;
> There seems to be no need for "goto err_out" here.

Hi, Yang. Thanks for being interested! I will update the code based on all the comments I received so far. 
Please also let me know if you have any suggestions or comments on the grouping method. 

Thanks,
Weilin

> 
> >
> > +err_out:
> > +	metricgroup__free_event_info(&event_info_list);
> > +	metricgroup__free_pmu_info(&pmu_info_list);
> >   	return ret;
> >   #undef RETURN_IF_NON_ZERO
> >   }
> >
> 
> 
> Thanks,
> Yang