linux-kernel - Re: [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230926215233.GA26968@redhat.com>
Date:   Tue, 26 Sep 2023 23:52:34 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Li kunyu <kunyu@...china.com>
Cc:     peterz@...radead.org, mcgrof@...nel.org,
        mathieu.desnoyers@...icios.com, elver@...gle.com,
        viro@...iv.linux.org.uk, dvyukov@...gle.com,
        vincent.whitchurch@...s.com, michael.christie@...cle.com,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kernel/signal: Remove unnecessary ‘NULL’ values from ucounts

On 09/26, Li kunyu wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags,
>  		 int override_rlimit, const unsigned int sigqueue_flags)
>  {
>  	struct sigqueue *q = NULL;
> -	struct ucounts *ucounts = NULL;
> +	struct ucounts *ucounts;
>  	long sigpending;

this looks obviously correct, so

Acked-by: Oleg Nesterov <oleg@...hat.com>


but you know, this change is so trivial, perhaps you should
resend this minor cleanup to kernel-janitors@...r.kernel.org

but let me add Andrew, perhaps he will take this patch...

Oleg.