linux-kernel - Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRKH5CTucrT5BFwC@infradead.org>
Date:   Tue, 26 Sep 2023 00:27:32 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Frank Li <Frank.Li@....com>
Cc:     christophe.jaillet@...adoo.fr, bhelgaas@...gle.com,
        hch@...radead.org, imx@...ts.linux.dev, kw@...ux.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        lpieralisi@...nel.org, minghuan.Lian@....com, mingkai.hu@....com,
        robh@...nel.org, roy.zang@....com
Subject: Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

> +	/* set 64-bit DMA mask and coherent DMA mask */
> +	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));

The comment is a bit silly :)

> +	if (ret)
> +		return ret;

Also no need to check the return value when setting a 64-bit mask,
but I guess it desn't hurt here.