linux-kernel - Re: [PATCH] Input: i8042 - add quirk for Lenovo ThinkPad T14 Gen 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbcf0fee-b97d-8f47-9df4-44bc1b475144@redhat.com>
Date:   Tue, 26 Sep 2023 12:37:08 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Jonathan Denose <jdenose@...omium.org>, linux-input@...r.kernel.org
Cc:     Jonathan Denose <jdenose@...gle.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        Mattijs Korpershoek <mkorpershoek@...libre.com>,
        Takashi Iwai <tiwai@...e.de>,
        Werner Sembach <wse@...edocomputers.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: i8042 - add quirk for Lenovo ThinkPad T14 Gen 1

Hi,

On 9/25/23 23:33, Jonathan Denose wrote:
> The ThinkPad T14 Gen 1 touchpad works fine except that clicking
> and dragging by tapping the touchpad or depressing the touchpad
> do not work. Disabling PNP for controller setting discovery enables
> click and drag without negatively impacting other touchpad features.
> 
> Signed-off-by: Jonathan Denose <jdenose@...gle.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
> 
>  drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
> index 1724d6cb8649d..c487047d878cd 100644
> --- a/drivers/input/serio/i8042-acpipnpio.h
> +++ b/drivers/input/serio/i8042-acpipnpio.h
> @@ -830,6 +830,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
>  		},
>  		.driver_data = (void *)(SERIO_QUIRK_RESET_ALWAYS)
>  	},
> +	{
> +		/* Lenovo ThinkPad T14 Gen 1*/
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "20S0002UUS")
> +		},
> +		.driver_data = (void *)(SERIO_QUIRK_NOPNP)
> +	},
>  	{
>  		/* Lenovo ThinkPad Twist S230u */
>  		.matches = {