linux-kernel - Re: [PATCH 02/40] soc/aspeed: aspeed-lpc-snoop: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <39fe757e-0b0c-4aa0-9150-29bf4e255788@app.fastmail.com>
Date:   Tue, 26 Sep 2023 11:00:44 +0930
From:   "Andrew Jeffery" <andrew@...id.au>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        "Joel Stanley" <joel@....id.au>
Cc:     "Rob Herring" <robh@...nel.org>, "Arnd Bergmann" <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>
Subject: Re: [PATCH 02/40] soc/aspeed: aspeed-lpc-snoop: Convert to platform remove
 callback returning void



On Mon, 25 Sep 2023, at 19:24, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Andrew Jeffery <andrew@...id.au>