linux-kernel - Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in ca8210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38f11c6a.2d287.18ad18184c8.Coremail.dinghao.liu@zju.edu.cn>
Date:   Tue, 26 Sep 2023 20:40:40 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Miquel Raynal" <miquel.raynal@...tlin.com>
Cc:     "Alexander Aring" <alex.aring@...il.com>,
        "Stefan Schmidt" <stefan@...enfreihafen.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Marcel Holtmann" <marcel@...tmann.org>,
        "Harry Morris" <harrymorris12@...il.com>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] ieee802154: ca8210: Fix a potential UAF in
 ca8210_probe

> Missing Cc stable, this needs to be backported.

I will cc stable (stable@...r.kernel.org) for the next version, thanks!
> > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> > index aebb19f1b3a4..b35c6f59bd1a 100644
> > --- a/drivers/net/ieee802154/ca8210.c
> > +++ b/drivers/net/ieee802154/ca8210.c
> > @@ -2759,7 +2759,6 @@ static int ca8210_register_ext_clock(struct spi_device *spi)
> >  	}
> >  	ret = of_clk_add_provider(np, of_clk_src_simple_get, priv->clk);
> >  	if (ret) {
> > -		clk_unregister(priv->clk);
> >  		dev_crit(
> >  			&spi->dev,
> >  			"Failed to register external clock as clock provider\n"
> 
> I was hoping you would simplify this function a bit more.

I understand. In the next patch version, I will just return of_clk_add_provider(). 

> 
> > @@ -2780,7 +2779,7 @@ static void ca8210_unregister_ext_clock(struct spi_device *spi)
> >  {
> >  	struct ca8210_priv *priv = spi_get_drvdata(spi);
> >  
> > -	if (!priv->clk)
> > +	if (IS_ERR_OR_NULL(priv->clk))
> >  		return
> >  
> >  	of_clk_del_provider(spi->dev.of_node);
> 
> Alex, Stefan, who handles wpan and wpan/next this release?
>
 
Is there any problem I need to handle in the next patch?

Regards,
Dinghao