[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230926-dugout-movable-0f9fb1218cdb@spud>
Date: Tue, 26 Sep 2023 13:58:42 +0100
From: Conor Dooley <conor@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Rob Clark <robdclark@...il.com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Sean Paul <sean@...rly.run>,
Marijn Suijten <marijn.suijten@...ainline.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Kuogee Hsieh <quic_khsieh@...cinc.com>,
Del Regno <angelogioacchino.delregno@...ainline.org>,
Loic Poulain <loic.poulain@...aro.org>,
Krishna Manikandan <quic_mkrishn@...cinc.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Robert Foss <rfoss@...nel.org>,
Neil Armstrong <neil.armstrong@...aro.org>,
linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: display: msm: Make
"additionalProperties: true" explicit
On Mon, Sep 25, 2023 at 04:24:25PM -0500, Rob Herring wrote:
> Make it explicit that child nodes have additional properties and the
> child node schema is not complete. The complete schemas are applied
> separately based the compatible strings.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
I cross-checked only a handful of these...
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks,
Conor.
> ---
> .../bindings/display/msm/qcom,msm8998-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,qcm2290-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sc7180-mdss.yaml | 8 ++++++++
> .../bindings/display/msm/qcom,sc7280-mdss.yaml | 10 ++++++++++
> .../bindings/display/msm/qcom,sc8280xp-mdss.yaml | 4 ++++
> .../bindings/display/msm/qcom,sdm845-mdss.yaml | 8 ++++++++
> .../bindings/display/msm/qcom,sm6115-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sm6125-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sm6350-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sm8150-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sm8250-mdss.yaml | 6 ++++++
> .../bindings/display/msm/qcom,sm8350-mdss.yaml | 8 ++++++++
> .../bindings/display/msm/qcom,sm8450-mdss.yaml | 8 ++++++++
> .../bindings/display/msm/qcom,sm8550-mdss.yaml | 8 ++++++++
> 15 files changed, 102 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> index e320ab1de6de..2d9edab5a30d 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,msm8998-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,msm8998-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -52,6 +56,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-10nm-8998
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> index 4184b84d4c21..5ad155612b6c 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,qcm2290-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-ctrl-6g-qcm2290
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-14nm-2290
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> index 3b9c103e504a..3432a2407caa 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sc7180-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sc7180-dp
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -64,6 +70,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> index 43500dad66e7..bbb727831fca 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.yaml
> @@ -44,18 +44,24 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sc7280-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sc7280-dp
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -64,12 +70,16 @@ patternProperties:
>
> "^edp@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sc7280-edp
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> enum:
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> index db680fb12b6a..af79406e1604 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sc8280xp-mdss.yaml
> @@ -34,12 +34,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sc8280xp-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> enum:
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> index d6d7ac1b2ef8..6e8b69e5ec62 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml
> @@ -42,18 +42,24 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sdm845-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sdm845-dp
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -62,6 +68,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> index 17221b62a642..dde5c2acead5 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml
> @@ -32,12 +32,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm6115-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> oneOf:
> @@ -50,6 +54,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-14nm-2290
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> index 57f0e3647711..671c2c2aa896 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm6125-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -57,6 +61,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm6125-dsi-phy-14nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> index db255b1f4c20..e1dcb453762e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm6350-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -57,6 +61,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-10nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> index 30d36fffaedb..b15c3950f09d 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml
> @@ -43,12 +43,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm6375-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -57,6 +61,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm6375-dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> index 54cdaa827cd3..a2a8be7f64a9 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml
> @@ -47,12 +47,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8150-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -61,6 +65,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> index e887f031b8be..994975909fea 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.yaml
> @@ -46,12 +46,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8250-dpu
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -60,6 +64,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,dsi-phy-7nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> index 60d4aae1131b..163fc83c1e80 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8350-mdss.yaml
> @@ -48,18 +48,24 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8350-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8350-dp
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -68,6 +74,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8350-dsi-phy-5nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> index bb22940b9385..001b26e65301 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8450-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -52,6 +56,8 @@ patternProperties:
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -60,6 +66,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8450-dsi-phy-5nm
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> index 48aea8005c86..1ea50a2c7c8e 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml
> @@ -38,12 +38,16 @@ properties:
> patternProperties:
> "^display-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8550-dpu
>
> "^displayport-controller@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -52,6 +56,8 @@ patternProperties:
>
> "^dsi@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> items:
> @@ -60,6 +66,8 @@ patternProperties:
>
> "^phy@[0-9a-f]+$":
> type: object
> + additionalProperties: true
> +
> properties:
> compatible:
> const: qcom,sm8550-dsi-phy-4nm
> --
> 2.40.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists