linux-kernel - Re: [PATCH v4] cdx: add MSI support for CDX bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <592f6e76-92cd-fc80-95a0-d1a4aaf81bca@amd.com>
Date:   Tue, 26 Sep 2023 18:36:38 +0530
From:   "Gupta, Nipun" <nipun.gupta@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     maz@...nel.org, tglx@...utronix.de, jgg@...pe.ca,
        linux-kernel@...r.kernel.org, git@....com, harpreet.anand@....com,
        pieter.jansen-van-vuuren@....com, nikhil.agarwal@....com,
        michal.simek@....com, abhijit.gangurde@....com,
        srivatsa@...il.mit.edu
Subject: Re: [PATCH v4] cdx: add MSI support for CDX bus



On 9/26/2023 3:25 PM, Greg KH wrote:
> On Tue, Sep 26, 2023 at 03:18:58PM +0530, Gupta, Nipun wrote:
>> Hi Greg,
>>
>> On 9/11/2023 7:22 PM, Nipun Gupta wrote:
>>> Add CDX-MSI domain per CDX controller with gic-its domain as
>>> a parent, to support MSI for CDX devices. CDX devices allocate
>>> MSIs from the CDX domain. Also, introduce APIs to alloc and free
>>> IRQs for CDX domain.
>>>
>>> In CDX subsystem firmware is a controller for all devices and
>>> their configuration. CDX bus controller sends all the write_msi_msg
>>> commands to firmware running on RPU and the firmware interfaces with
>>> actual devices to pass this information to devices
>>>
>>> Since, CDX controller is the only way to communicate with the Firmware
>>> for MSI write info, CDX domain per controller required in contrast to
>>> having a CDX domain per device.
>>>
>>> Co-developed-by: Nikhil Agarwal <nikhil.agarwal@....com>
>>> Signed-off-by: Nikhil Agarwal <nikhil.agarwal@....com>
>>> Co-developed-by: Abhijit Gangurde <abhijit.gangurde@....com>
>>> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@....com>
>>> Signed-off-by: Nipun Gupta <nipun.gupta@....com>
>>> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
>>> Tested-by: Nikhil Agarwal <nikhil.agarwal@....com>
>>
>> Please help in making progress on this patch. Is there anything that needs
>> to be updated in this patch for CDX bus?
> 
> $ mdfrm -c ~/mail/todo/
> 2031 messages in /home/gregkh/mail/todo/
> 
> So perhaps help in reviewing other pending patches for other subsystems?
> It's in my queue, but have been traveling for 2 weeks for conferences,
> will be catching up next week when I get a chance.
> 
> Also, you need to get the msi/interrupt developers to agree with this,
> why not get their review and acceptance first?

Thanks for quick response and sorry for prodding. I will check with 
Thomas/Marc for their feedback.

Regards,
Nipun

> 
> thanks,
> 
> greg k-h