linux-kernel - RE: [PATCH v3] regulator: max20086: Drop ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB59227E269E915E313109524686C3A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Tue, 26 Sep 2023 15:36:04 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Biju Das <biju.das.au@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Subject: RE: [PATCH v3] regulator: max20086: Drop ID table

Hi Mark,

Thanks for the feedback.

> Subject: Re: [PATCH v3] regulator: max20086: Drop ID table
> 
> On Sun, Sep 10, 2023 at 07:54:44AM +0100, Biju Das wrote:
> > The driver has an ID table, but it uses the wrong API for retrieving
> > match data and that will lead to a crash, if it is instantiated by
> > user space or using ID. From this, there is no user for the ID table
> > and let's drop it from the driver as it saves some memory.
> 
> This doesn't apply against current code, please check and resend.

V2 version is accepted and is in next [1]. So I would like to
drop this patch as there is no harm in supporting both OF/ID
tables. Please let me know if you think otherwise.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20230926&id=9d9cd8e6a4572efa328ef72a83bbc78a39deca37

Cheers,
Biju