linux-kernel - Re: [RFC PATCH 16/25] perf stat: Update keyword core to default_core to adjust to the changes for events with no unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ffd2c76-3499-a921-58b9-eb71432e59ff@linux.intel.com>
Date:   Tue, 26 Sep 2023 12:25:04 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     weilin.wang@...el.com, Ian Rogers <irogers@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>
Cc:     linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Perry Taylor <perry.taylor@...el.com>,
        Samantha Alt <samantha.alt@...el.com>,
        Caleb Biggers <caleb.biggers@...el.com>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RFC PATCH 16/25] perf stat: Update keyword core to default_core
 to adjust to the changes for events with no unit



On 2023-09-25 2:18 a.m., weilin.wang@...el.com wrote:
> From: Weilin Wang <weilin.wang@...el.com>
>

Description?

Shouldn't the default_core be used when the keyword core is first
introduced?

Thanks,
Kan

> Signed-off-by: Weilin Wang <weilin.wang@...el.com>
> ---
>  tools/perf/pmu-events/jevents.py | 2 +-
>  tools/perf/util/metricgroup.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> index 5614bc203..d8c2fd258 100755
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
> @@ -303,7 +303,7 @@ class JsonEvent:
>            'cpu_core': 'cpu_core',
>            'cpu_atom': 'cpu_atom',
>            'ali_drw': 'ali_drw',
> -          'Core': 'core',
> +          'Core': 'default_core',
>        }
>        return table[unit] if unit in table else f'uncore_{unit.lower()}'
>  
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index 2e7a8e315..7884cb036 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -2085,7 +2085,7 @@ static int hw_aware_build_grouping(struct expr_parse_ctx *ctx __maybe_unused,
>  		pr_debug("found event %s\n", id);
>  		if (!strncmp(id, special_pattern, strlen(special_pattern))) {
>  			struct metricgroup__event_info *event;
> -			event = event_info__new(id, "core", "0", true);
> +			event = event_info__new(id, "default_core", "0", true);
>  			if (!event) {
>  				ret = -ENOMEM;
>  				goto err_out;