linux-kernel - Re: [PATCH] dmaengine: idxd: rate limit printk in misc interrupt thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8199226c-9642-e089-8dce-64ac8483efea@intel.com>
Date:   Tue, 26 Sep 2023 11:30:53 -0500
From:   Lijun Pan <lijun.pan@...el.com>
To:     Fenghua Yu <fenghua.yu@...el.com>, Vinod Koul <vkoul@...nel.org>,
        <dmaengine@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
CC:     Dave Jiang <dave.jiang@...el.com>,
        Sanjay Kumar <sanjay.k.kumar@...el.com>
Subject: Re: [PATCH] dmaengine: idxd: rate limit printk in misc interrupt
 thread



On 9/23/2023 7:23 PM, Fenghua Yu wrote:
> From: Dave Jiang <dave.jiang@...el.com>
> 
> Add rate limit to the dev_warn() call in the misc interrupt thread. This
> limits dmesg getting spammed if a descriptor submitter is spamming bad
> descriptors with invalid completion records and resulting the errors being
> continuously reported by the misc interrupt handling thread.
> 
> Reported-by: Sanjay Kumar <sanjay.k.kumar@...el.com>
> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
> ---

Acked-by: Lijun Pan <lijun.pan@...el.com>

> 
> This patch was sent to dmaengine mailing list before:
> https://lore.kernel.org/all/165125377735.312075.15715853788802098990.stgit@djiang5-desk3.ch.intel.com/
> But it hasn't be merged into upstream yet. Add my Reviewed-by tag
> and re-send it. No code or commit message change.
> 
>   drivers/dma/idxd/irq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 041be6a4dec4..8e895a1e1881 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -430,8 +430,8 @@ irqreturn_t idxd_misc_thread(int vec, void *data)
>   		val |= IDXD_INTC_ERR;
>   
>   		for (i = 0; i < 4; i++)
> -			dev_warn(dev, "err[%d]: %#16.16llx\n",
> -				 i, idxd->sw_err.bits[i]);
> +			dev_warn_ratelimited(dev, "err[%d]: %#16.16llx\n",
> +					     i, idxd->sw_err.bits[i]);
>   		err = true;
>   	}
>