linux-kernel - Re: [PATCH v4] PM: Fix symbol export for _SIMPLE_ variants of _PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Sep 2023 18:42:07 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Paul Cercueil <paul@...pouillou.net>,
        Raag Jadav <raag.jadav@...el.com>
Cc:     len.brown@...el.com, pavel@....cz, Jonathan.Cameron@...wei.com,
        andriy.shevchenko@...ux.intel.com, rf@...nsource.cirrus.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        mallikarjunappa.sangannavar@...el.com, bala.senthil@...el.com
Subject: Re: [PATCH v4] PM: Fix symbol export for _SIMPLE_ variants of _PM_OPS()

On Mon, Sep 25, 2023 at 11:01 AM Paul Cercueil <paul@...pouillou.net> wrote:
>
> Hi,
>
> Le vendredi 22 septembre 2023 à 11:15 +0530, Raag Jadav a écrit :
> > Currently EXPORT_*_SIMPLE_DEV_PM_OPS() use EXPORT_*_DEV_PM_OPS() set
> > of macros to export dev_pm_ops symbol, which export the symbol in
> > case
> > CONFIG_PM=y but don't take CONFIG_PM_SLEEP into consideration.
> >
> > Since _SIMPLE_ variants of _PM_OPS() do not include runtime PM
> > handles
> > and are only used in case CONFIG_PM_SLEEP=y, we should not be
> > exporting
> > dev_pm_ops symbol for them in case CONFIG_PM_SLEEP=n.
> >
> > This can be fixed by having two distinct set of export macros for
> > both
> > _RUNTIME_ and _SIMPLE_ variants of _PM_OPS(), such that the export of
> > dev_pm_ops symbol used in each variant depends on CONFIG_PM and
> > CONFIG_PM_SLEEP respectively.
> >
> > Introduce _DEV_SLEEP_PM_OPS() set of export macros for _SIMPLE_
> > variants
> > of _PM_OPS(), which export dev_pm_ops symbol only in case
> > CONFIG_PM_SLEEP=y
> > and discard it otherwise.
> >
> > Fixes: 34e1ed189fab ("PM: Improve EXPORT_*_DEV_PM_OPS macros")
> > Signed-off-by: Raag Jadav <raag.jadav@...el.com>
>
> Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Applied as 6.7 material, thanks!