linux-kernel - Re: [PATCH v2] Input: axp20x-pek - avoid needless newline removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64W3oa6g-Ln2wVqXU4eVa-tY=zhvooAXckzDve8_fR-gQ@mail.gmail.com>
Date:   Tue, 26 Sep 2023 11:10:31 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Justin Stitt <justinstitt@...gle.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] Input: axp20x-pek - avoid needless newline removal

On Tue, Sep 26, 2023 at 2:00 AM Kees Cook <keescook@...omium.org> wrote:
>
> On Mon, Sep 25, 2023 at 04:31:05AM +0000, Justin Stitt wrote:
> > This code is doing more work than it needs to.
> >
> > Before handing off `val_str` to `kstrtouint()` we are eagerly removing
> > any trailing newline which requires copying `buf`, validating it's
> > length and checking/replacing any potential newlines.
> >
> > kstrtouint() handles this implicitly:
> > kstrtouint ->
> >   kstrotoull -> (documentation)
> > |   /**
> > |    * kstrtoull - convert a string to an unsigned long long
> > |    * @s: The start of the string. The string must be null-terminated, and may also
> > |    *  include a single newline before its terminating null. The first character
> > |    ...
> >
> > Let's remove the redundant functionality and let kstrtouint handle it.
> >
> > Link: https://github.com/KSPP/linux/issues/90
> > Cc: linux-hardening@...r.kernel.org
> > Suggested-by: Kees Cook <keescook@...omium.org>
> > Signed-off-by: Justin Stitt <justinstitt@...gle.com>
>
> This looks much cleaner. Thanks!
>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Chen-Yu Tsai <wens@...e.org>