linux-kernel - RE: [PATCH v5 2/8] x86/resctrl: Prepare for different scope for control/monitor operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB608392F4682FE9EA0EC618C8FCC3A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date:   Tue, 26 Sep 2023 17:45:50 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "babu.moger@....com" <babu.moger@....com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        Peter Newman <peternewman@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Shuah Khan <skhan@...uxfoundation.org>,
        "x86@...nel.org" <x86@...nel.org>
CC:     Shaopeng Tan <tan.shaopeng@...itsu.com>,
        James Morse <james.morse@....com>,
        Jamie Iles <quic_jiles@...cinc.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH v5 2/8] x86/resctrl: Prepare for different scope for
 control/monitor operations

>> Create separate domain lists for control and monitor operations.
>> 
>> No important functional change. But note that errors during
>
> Its better to remove the line "No important functional change."

Will drop it.

>>  	struct list_head	domains;
>> +	struct list_head	mondomains;
>
> For consistancy, its better to rename it to mon_domains(to be inline with
> mon_scope, mon_capable).

Again, you are thinking like Reinette! You'll be a resctrl maintainer soon.

>> +struct rdt_domain *rdt_find_ctrldomain(struct list_head *h, int id,
>> +				       struct list_head **pos);
>> +struct rdt_domain *rdt_find_mondomain(struct list_head *h, int id,
>> +				      struct list_head **pos);
>
> For consistancy, it is better to rename to rdt_find_ctrl_domain and
> rdt_find_mon_domain respectively.

Agreed.

Thanks for the review.

-Tony