linux-kernel - Re: [External] Re: [PATCH] i2c: aspeed: Fix i2c bus hang in slave read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XeO404ok+B+k4U_bdFE3yYebzT-UNcTqcHStJfEnDh6jg@mail.gmail.com>
Date:   Wed, 27 Sep 2023 02:42:46 +0000
From:   Joel Stanley <joel@....id.au>
To:     Jian Zhang <zhangjian.3032@...edance.com>
Cc:     Tommy Huang <tommy_huang@...eedtech.com>,
        brendan.higgins@...ux.dev, benh@...nel.crashing.org,
        andrew@...id.au, zhangjian3032@...il.com, yulei.sh@...edance.com,
        xiexinnan@...edance.com,
        "open list:ARM/ASPEED I2C DRIVER" <linux-i2c@...r.kernel.org>,
        "moderated list:ARM/ASPEED I2C DRIVER" <openbmc@...ts.ozlabs.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@...ts.ozlabs.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [External] Re: [PATCH] i2c: aspeed: Fix i2c bus hang in slave read

On Fri, 22 Sept 2023 at 14:39, Jian Zhang <zhangjian.3032@...edance.com> wrote:
> >
> > Tommy has submitted a similar fix:
> >
> >  https://lore.kernel.org/linux-i2c/20230906004910.4157305-1-tommy_huang@aspeedtech.com/
> >
> > His change is very heavy handed; it reinitialises the bus including
> > re-parsing the device tree (!).
> >
> > Should we have merged this fix instead? If not, are you able to
> > confirm that his change fixes your issue?
>
> I feel it's for solving the same issue, but I think this patch is
> missing the action
> `bus->slave_state = ASPEED_I2C_SLAVE_INACTIVE;`,
>  which means it can't resolve my problem. @Tommy, can you help confirm this?

You're right, it doesn't change the slave_state at all.

Unfortunately, despite no acks from the maintainers, this patch has
now been merged and backported to stable. We should complete the fix,
or revert it asap.