linux-kernel - Re: [PATCH 1/1] drm/amdkfd: Fix unaligned doorbell absolute offset for gfx8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd40809d-bb6a-dfc6-6619-eb467a68c9bf@amd.com>
Date:   Wed, 27 Sep 2023 21:55:57 +0530
From:   "Yadav, Arvind" <arvyadav@....com>
To:     Arvind Yadav <Arvind.Yadav@....com>, Christian.Koenig@....com,
        alexander.deucher@....com, shashank.sharma@....com,
        Xinhui.Pan@....com, airlied@...il.com, daniel@...ll.ch,
        Felix.Kuehling@....com
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drm/amdkfd: Fix unaligned doorbell absolute offset
 for gfx8

Adding Felix.Kuehling@....com for review.

Thanks
~Arvind

On 9/27/2023 9:46 PM, Arvind Yadav wrote:
> This patch is to adjust the absolute doorbell offset
> against the doorbell id considering the doorbell
> size of 32/64 bit.
>
> Cc: Christian Koenig <christian.koenig@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Shashank Sharma <shashank.sharma@....com>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@....com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 11 ++++++++++-
>   1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 0d3d538b64eb..c327f7f604d7 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -407,7 +407,16 @@ static int allocate_doorbell(struct qcm_process_device *qpd,
>   
>   	q->properties.doorbell_off = amdgpu_doorbell_index_on_bar(dev->adev,
>   								  qpd->proc_doorbells,
> -								  q->doorbell_id);
> +								  0);
> +
> +	/* Adjust the absolute doorbell offset against the doorbell id considering
> +	 * the doorbell size of 32/64 bit.
> +	 */
> +	if (!KFD_IS_SOC15(dev))
> +		q->properties.doorbell_off += q->doorbell_id;
> +	else
> +		q->properties.doorbell_off += q->doorbell_id * 2;
> +
>   	return 0;
>   }
>