linux-kernel - Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <e8479eff-a5cb-41b0-8bf6-bcc20ccbecfb@augustwikerfors.se>
Date:   Wed, 27 Sep 2023 19:41:43 +0200
From:   August Wikerfors <git@...ustwikerfors.se>
To:     Sven Frotscher <sven.frotscher@...il.com>
Cc:     broonie@...nel.org, alsa-devel@...a-project.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        mario.limonciello@....com, regressions@...ts.linux.dev
Subject: Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo 82YM

Hi,

On 2023-09-27 18:22, Sven Frotscher wrote:
> 
> Like the Lenovo 82TL, 82V2, 82QF and 82UG, the 82YM (Yoga 7 14ARP8)
> requires an entry in the quirk list to enable the internal microphone.
> The latter two received similar fixes in commit 1263cc0f, see
> https://lore.kernel.org/r/20230911213409.6106-1-git@augustwikerfors.se.
> 
> Signed-off-by: Sven Frotscher <sven.frotscher@...il.com>
Since this fixes a regression caused by commit c008323fe361 which has
been backported to stable, please add "Fixes:" and "Cc:" tags above the
"Signed-off-by:" tag to ensure the fix also gets backported in a timely
manner [1]:

Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo 82SJ")
Cc: stable@...r.kernel.org

> ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 3d8a51351e29..e3d2b9d01552 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -241,6 +241,13 @@ static const struct dmi_system_id 
> yc_acp_quirk_table[] = {
>  >..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
>  >..>...}
>  >..},
> +>..{
> +>..>....driver_data = &acp6x_card,
> +>..>....matches = {
> +>..>...>...DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +>..>...>...DMI_MATCH(DMI_PRODUCT_NAME, "82YM"),
> +>..>...}
> +>..},
>  >..{
>  >..>....driver_data = &acp6x_card,
>  >..>....matches = {
Your e-mail client seems to have mangled the leading whitespace here,
which will prevent the patch from applying cleanly. It is strongly
recommended [2] to use git send-email for sending patches, see [3] for a
tutorial on how to set up and use it. For other e-mail clients, see [4].

[1] https://www.kernel.org/doc/html/latest/process/handling-regressions.html#what-s-important-when-fixing-regressions
[2] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
[3] https://git-send-email.io/
[4] https://www.kernel.org/doc/html/latest/process/email-clients.html

Regards,
August Wikerfors