linux-kernel - Re: [PATCH] [v3] scsi: zfcp: Fix a double put in zfcp_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169584315413.1272983.1280092821984155852.b4-ty@oracle.com>
Date:   Wed, 27 Sep 2023 15:34:00 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, Steffen Maier <maier@...ux.ibm.com>,
        Benjamin Block <bblock@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Christof Schmitt <christof.schmitt@...ibm.com>,
        James Bottomley <James.Bottomley@...e.de>,
        Swen Schillig <swen@...t.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v3] scsi: zfcp: Fix a double put in zfcp_port_enqueue

On Sat, 23 Sep 2023 18:37:23 +0800, Dinghao Liu wrote:

> When device_register() fails, zfcp_port_release() will be called
> after put_device(). As a result, zfcp_ccw_adapter_put() will be
> called twice: one in zfcp_port_release() and one in the error path
> after device_register(). So the reference on the adapter object is
> doubly put, which may lead to a premature free. Fix this by adjusting
> the error tag after device_register().
> 
> [...]

Applied to 6.6/scsi-fixes, thanks!

[1/1] scsi: zfcp: Fix a double put in zfcp_port_enqueue
      https://git.kernel.org/mkp/scsi/c/b481f644d917

-- 
Martin K. Petersen	Oracle Linux Engineering