| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <71833cb5-1dfc-42d3-a2a2-6abe8520aee2@sifive.com>
Date: Wed, 27 Sep 2023 15:06:01 -0500
From: Samuel Holland <samuel.holland@...ive.com>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Guo Ren <guoren@...nel.org>,
Fu Wei <wefu@...hat.com>, linux-riscv@...ts.infradead.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Subject: Re: [PATCH 2/2] usb: dwc3: add T-HEAD TH1520 usb driver
On 2023-09-27 11:42 AM, Jisheng Zhang wrote:
> Adds TH1520 Glue layer to support USB controller on T-HEAD TH1520 SoC.
> There is a DesignWare USB3 DRD core in TH1520 SoCs, the dwc3 core is
> the child of this USB wrapper module device.
>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
> MAINTAINERS | 1 +
> drivers/usb/dwc3/Kconfig | 9 +++
> drivers/usb/dwc3/Makefile | 1 +
> drivers/usb/dwc3/dwc3-thead.c | 119 ++++++++++++++++++++++++++++++++++
> 4 files changed, 130 insertions(+)
> create mode 100644 drivers/usb/dwc3/dwc3-thead.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..d55e40060c46 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18481,6 +18481,7 @@ M: Fu Wei <wefu@...hat.com>
> L: linux-riscv@...ts.infradead.org
> S: Maintained
> F: arch/riscv/boot/dts/thead/
> +F: drivers/usb/dwc3/dwc3-thead.c
>
> RNBD BLOCK DRIVERS
> M: Md. Haris Iqbal <haris.iqbal@...os.com>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 98efcbb76c88..1b02f4f55b47 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -178,4 +178,13 @@ config USB_DWC3_OCTEON
> Only the host mode is currently supported.
> Say 'Y' or 'M' here if you have one such device.
>
> +config USB_DWC3_THEAD
> + tristate "T-HEAD Platform"
> + depends on ARCH_THEAD || COMPILE_TEST
> + default USB_DWC3
> + help
> + Support T-HEAD platform with DesignWare Core USB3 IP.
> + Only the host mode is currently supported.
> + Say 'Y' or 'M' here if you have one such device.
> +
> endif
> diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
> index fe1493d4bbe5..9523a51dd279 100644
> --- a/drivers/usb/dwc3/Makefile
> +++ b/drivers/usb/dwc3/Makefile
> @@ -55,3 +55,4 @@ obj-$(CONFIG_USB_DWC3_QCOM) += dwc3-qcom.o
> obj-$(CONFIG_USB_DWC3_IMX8MP) += dwc3-imx8mp.o
> obj-$(CONFIG_USB_DWC3_XILINX) += dwc3-xilinx.o
> obj-$(CONFIG_USB_DWC3_OCTEON) += dwc3-octeon.o
> +obj-$(CONFIG_USB_DWC3_THEAD) += dwc3-thead.o
> diff --git a/drivers/usb/dwc3/dwc3-thead.c b/drivers/usb/dwc3/dwc3-thead.c
> new file mode 100644
> index 000000000000..999b1e319c72
> --- /dev/null
> +++ b/drivers/usb/dwc3/dwc3-thead.c
> @@ -0,0 +1,119 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * dwc3-thead.c - T-HEAD platform specific glue layer
> + *
> + * Inspired by dwc3-of-simple.c
> + *
> + * Copyright (C) 2021 Alibaba Group Holding Limited.
> + * Copyright (C) 2023 Jisheng Zhang <jszhang@...nel.org>
> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + */
> +
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +
> +#include "core.h"
> +
> +#define USB_SSP_EN 0x34
> +#define REF_SSP_EN BIT(0)
> +#define USB_SYS 0x3c
> +#define COMMONONN BIT(0)
> +
> +#define USB3_DRD_SWRST 0x14
> +#define USB3_DRD_PRST BIT(0)
> +#define USB3_DRD_PHYRST BIT(1)
> +#define USB3_DRD_VCCRST BIT(2)
> +#define USB3_DRD_RSTMASK (USB3_DRD_PRST | USB3_DRD_PHYRST | USB3_DRD_VCCRST)
> +
> +struct dwc3_thead {
> + void __iomem *base;
> + struct regmap *misc_sysreg;
> + struct regulator *vbus;
> +};
> +
> +static void dwc3_thead_optimize_power(struct dwc3_thead *thead)
> +{
> + u32 val;
> +
> + /* config usb top within USB ctrl & PHY reset */
> + regmap_update_bits(thead->misc_sysreg, USB3_DRD_SWRST,
> + USB3_DRD_RSTMASK, USB3_DRD_PRST);
> +
> + /*
> + * dwc reg also need to be configed to save power
> + * 1. set USB_SYS[COMMONONN]
> + * 2. set DWC3_GCTL[SOFITPSYNC](done by core.c)
> + * 3. set GUSB3PIPECTL[SUSPENDEN] (done by core.c)
> + */
> + val = readl(thead->base + USB_SYS);
> + val |= COMMONONN;
> + writel(val, thead->base + USB_SYS);
> + val = readl(thead->base + USB_SSP_EN);
> + val |= REF_SSP_EN;
> + writel(val, thead->base + USB_SSP_EN);
> +
> + regmap_update_bits(thead->misc_sysreg, USB3_DRD_SWRST,
> + USB3_DRD_RSTMASK, USB3_DRD_RSTMASK);
> +}
> +
> +static int dwc3_thead_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct device_node *np = dev->of_node;
> + struct dwc3_thead *thead;
> + int ret;
> +
> + thead = devm_kzalloc(&pdev->dev, sizeof(*thead), GFP_KERNEL);
> + if (!thead)
> + return -ENOMEM;
> +
> + platform_set_drvdata(pdev, thead);
No need to set driver data, since you never access it.
> +
> + ret = devm_regulator_get_enable_optional(dev, "vbus");
> + if (ret < 0 && ret != -ENODEV)
> + return ret;
If you want to ignore -ENODEV, use the non-_optional variant.
> +
> + thead->misc_sysreg = syscon_regmap_lookup_by_phandle(np, "thead,misc-sysreg");
> + if (IS_ERR(thead->misc_sysreg))
> + return PTR_ERR(thead->misc_sysreg);
> +
> + thead->base = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(thead->base))
> + return PTR_ERR(thead->base);
> +
> + dwc3_thead_optimize_power(thead);
> +
> + return of_platform_populate(np, NULL, NULL, dev);
Using devm_of_platform_populate() will avoid the .remove_new hook.
Regards,
Samuel
> +}
> +
> +static void dwc3_thead_remove(struct platform_device *pdev)
> +{
> + of_platform_depopulate(&pdev->dev);
> +}
> +
> +static const struct of_device_id dwc3_thead_of_match[] = {
> + { .compatible = "thead,th1520-usb" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, dwc3_thead_of_match);
> +
> +static struct platform_driver dwc3_thead_driver = {
> + .probe = dwc3_thead_probe,
> + .remove_new = dwc3_thead_remove,
> + .driver = {
> + .name = "dwc3-thead",
> + .of_match_table = dwc3_thead_of_match,
> + },
> +};
> +module_platform_driver(dwc3_thead_driver);
> +
> +MODULE_ALIAS("platform:dwc3-thead");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("DesignWare DWC3 T-HEAD Glue Driver");
> +MODULE_AUTHOR("Jisheng Zhang <jszhang@...nel.org>");
Powered by blists - more mailing lists