linux-kernel - drivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202309280431.VyAxysqB-lkp@intel.com>
Date:   Thu, 28 Sep 2023 04:59:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     Benson Leung <bleung@...omium.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Prashant Malani <pmalani@...omium.org>
Subject: drivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast
 to restricted __le16

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   633b47cb009d09dc8f4ba9cdb3a0ca138809c7c7
commit: 3b3dd1f0dbfe92781c60f36ea5c22b26360f9909 platform/chrome: cros_ec_typec: Report SOP' PD revision from status
date:   2 years, 8 months ago
config: x86_64-randconfig-121-20230928 (https://download.01.org/0day-ci/archive/20230928/202309280431.VyAxysqB-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230928/202309280431.VyAxysqB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309280431.VyAxysqB-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/platform/chrome/cros_ec_typec.c:900:39: sparse: sparse: cast to restricted __le16

vim +900 drivers/platform/chrome/cros_ec_typec.c

   870	
   871	static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num)
   872	{
   873		struct ec_response_typec_status resp;
   874		struct ec_params_typec_status req = {
   875			.port = port_num,
   876		};
   877		int ret;
   878	
   879		ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_STATUS, &req, sizeof(req),
   880					    &resp, sizeof(resp));
   881		if (ret < 0) {
   882			dev_warn(typec->dev, "EC_CMD_TYPEC_STATUS failed for port: %d\n", port_num);
   883			return;
   884		}
   885	
   886		/* Handle any events appropriately. */
   887		if (resp.events & PD_STATUS_EVENT_SOP_DISC_DONE && !typec->ports[port_num]->sop_disc_done) {
   888			ret = cros_typec_handle_sop_disc(typec, port_num);
   889			if (ret < 0)
   890				dev_err(typec->dev, "Couldn't parse SOP Disc data, port: %d\n", port_num);
   891			else
   892				typec->ports[port_num]->sop_disc_done = true;
   893		}
   894	
   895		if (resp.events & PD_STATUS_EVENT_SOP_PRIME_DISC_DONE &&
   896		    !typec->ports[port_num]->sop_prime_disc_done) {
   897			u16 sop_prime_revision;
   898	
   899			/* Convert BCD to the format preferred by the TypeC framework */
 > 900			sop_prime_revision = (le16_to_cpu(resp.sop_prime_revision) & 0xff00) >> 4;
   901			ret = cros_typec_handle_sop_prime_disc(typec, port_num, sop_prime_revision);
   902			if (ret < 0)
   903				dev_err(typec->dev, "Couldn't parse SOP' Disc data, port: %d\n", port_num);
   904			else
   905				typec->ports[port_num]->sop_prime_disc_done = true;
   906		}
   907	}
   908	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki