linux-kernel - Re: [PATCH] mmc: mmci: use peripheral flow control for STM32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Sep 2023 00:19:16 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ben Wolsieffer <ben.wolsieffer@...ring.com>
Cc:     linux-stm32@...md-mailman.stormreply.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Yann Gautier <yann.gautier@...s.st.com>,
        Christophe Kerello <christophe.kerello@...s.st.com>
Subject: Re: [PATCH] mmc: mmci: use peripheral flow control for STM32

Hi Ben,

thanks for your patch!

On Wed, Sep 27, 2023 at 8:47 PM Ben Wolsieffer
<ben.wolsieffer@...ring.com> wrote:

> @@ -378,6 +379,7 @@ struct variant_data {
>         u8                      dma_lli:1;
>         u32                     stm32_idmabsize_mask;
>         u32                     stm32_idmabsize_align;
> +       u8                      dma_flow_controller:1;

I've insisted that we use bool rather than u8:1, ut admittedly it is
nitpicking.

Either way:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij