[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8aab614e-1624-413d-693a-5934be6cdf8e@riseup.net>
Date: Wed, 27 Sep 2023 19:52:25 -0300
From: Arthur Grillo <arthurgrillo@...eup.net>
To: Maira Canal <mairacanal@...eup.net>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Maxime Ripard <mripard@...nel.org>,
Javier Martinez Canillas <javierm@...hat.com>,
Brendan Higgins <brendan.higgins@...ux.dev>,
David Gow <davidgow@...gle.com>
Cc: tales.aparecida@...il.com, andrealmeid@...eup.net,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
kunit-dev@...glegroups.com
Subject: Re: [PATCH 1/3] drm/tests: Fix kunit_release_action ctx argument
On 27/09/23 19:47, Maira Canal wrote:
> Hi Arthur,
>
> On 9/20/23 03:11, Arthur Grillo wrote:
>> The kunit_action_platform_driver_unregister is added with
>> &fake_platform_driver as ctx, but the kunit_release_action is called
>> pdev as ctx. Fix that by replacing it with &fake_platform_driver.
>>
>> Fixes: 4f2b0b583baa ("drm/tests: helpers: Switch to kunit actions")
>> Signed-off-by: Arthur Grillo <arthurgrillo@...eup.net>
>
> Reviewed-by: Maíra Canal <mairacanal@...eup.net>
>
> Do you need me to apply this patch to drm-misc-fixes?
Yes, please do, if possible.
Thanks,
~Arthur Grillo
>
> Best Regards,
> - Maíra
>
>> ---
>> drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.c
>> index 3d624ff2f651..3150dbc647ee 100644
>> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
>> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
>> @@ -118,7 +118,7 @@ void drm_kunit_helper_free_device(struct kunit *test, struct device *dev)
>> kunit_release_action(test,
>> kunit_action_platform_driver_unregister,
>> - pdev);
>> + &fake_platform_driver);
>> }
>> EXPORT_SYMBOL_GPL(drm_kunit_helper_free_device);
>>
Powered by blists - more mailing lists