[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZRTBFJPL3NwWpMSP@pidgin.makrotopia.org>
Date: Thu, 28 Sep 2023 00:56:04 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Frank Wunderlich <linux@...web.de>
Cc: linux-mediatek@...ts.infradead.org,
Frank Wunderlich <frank-w@...lic-files.de>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Amit Kucheria <amitk@...nel.org>,
Zhang Rui <rui.zhang@...el.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 4/4] thermal/drivers/mediatek/lvts_thermal: add mt7988
support
On Fri, Sep 22, 2023 at 07:50:20AM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@...lic-files.de>
>
> Add Support for Mediatek Filogic 880/MT7988 LVTS.
>
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
Tested-by: Daniel Golle <daniel@...rotopia.org>
> ---
> v3:
> - drop comments
>
> v2:
> - use 105°C for hw shutdown
> - move constants to binding file
> - change coeff.a to temp_factor and coeff.b to temp_offset
> - change to lvts to lvts-ap (Application Processor)
> - drop comments about efuse offsets
> - change comment of mt8195 to be similar to mt7988
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 38 +++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index c2669f405a94..23b4e0b3195c 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -82,6 +82,8 @@
> #define LVTS_GOLDEN_TEMP_DEFAULT 50
> #define LVTS_COEFF_A_MT8195 -250460
> #define LVTS_COEFF_B_MT8195 250460
> +#define LVTS_COEFF_A_MT7988 -204650
> +#define LVTS_COEFF_B_MT7988 204650
>
> #define LVTS_MSR_IMMEDIATE_MODE 0
> #define LVTS_MSR_FILTERED_MODE 1
> @@ -89,6 +91,7 @@
> #define LVTS_MSR_READ_TIMEOUT_US 400
> #define LVTS_MSR_READ_WAIT_US (LVTS_MSR_READ_TIMEOUT_US / 2)
>
> +#define LVTS_HW_SHUTDOWN_MT7988 105000
> #define LVTS_HW_SHUTDOWN_MT8195 105000
>
> #define LVTS_MINIMUM_THRESHOLD 20000
> @@ -1269,6 +1272,33 @@ static int lvts_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct lvts_ctrl_data mt7988_lvts_ap_data_ctrl[] = {
> + {
> + .cal_offset = { 0x00, 0x04, 0x08, 0x0c },
> + .lvts_sensor = {
> + { .dt_id = MT7988_CPU_0 },
> + { .dt_id = MT7988_CPU_1 },
> + { .dt_id = MT7988_ETH2P5G_0 },
> + { .dt_id = MT7988_ETH2P5G_1 }
> + },
> + .num_lvts_sensor = 4,
> + .offset = 0x0,
> + .hw_tshut_temp = LVTS_HW_SHUTDOWN_MT7988,
> + },
> + {
> + .cal_offset = { 0x14, 0x18, 0x1c, 0x20 },
> + .lvts_sensor = {
> + { .dt_id = MT7988_TOPS_0},
> + { .dt_id = MT7988_TOPS_1},
> + { .dt_id = MT7988_ETHWARP_0},
> + { .dt_id = MT7988_ETHWARP_1}
> + },
> + .num_lvts_sensor = 4,
> + .offset = 0x100,
> + .hw_tshut_temp = LVTS_HW_SHUTDOWN_MT7988,
> + }
> +};
> +
> static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = {
> {
> .cal_offset = { 0x04, 0x07 },
> @@ -1348,6 +1378,13 @@ static const struct lvts_ctrl_data mt8195_lvts_ap_data_ctrl[] = {
> }
> };
>
> +static const struct lvts_data mt7988_lvts_ap_data = {
> + .lvts_ctrl = mt7988_lvts_ap_data_ctrl,
> + .num_lvts_ctrl = ARRAY_SIZE(mt7988_lvts_ap_data_ctrl),
> + .temp_factor = LVTS_COEFF_A_MT7988,
> + .temp_offset = LVTS_COEFF_B_MT7988,
> +};
> +
> static const struct lvts_data mt8195_lvts_mcu_data = {
> .lvts_ctrl = mt8195_lvts_mcu_data_ctrl,
> .num_lvts_ctrl = ARRAY_SIZE(mt8195_lvts_mcu_data_ctrl),
> @@ -1363,6 +1400,7 @@ static const struct lvts_data mt8195_lvts_ap_data = {
> };
>
> static const struct of_device_id lvts_of_match[] = {
> + { .compatible = "mediatek,mt7988-lvts-ap", .data = &mt7988_lvts_ap_data },
> { .compatible = "mediatek,mt8195-lvts-mcu", .data = &mt8195_lvts_mcu_data },
> { .compatible = "mediatek,mt8195-lvts-ap", .data = &mt8195_lvts_ap_data },
> {},
> --
> 2.34.1
>
Powered by blists - more mailing lists