linux-kernel - Re: [PATCH 05/11] platform/x86:intel/pmc: Move get_low_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <850d1c1b6ef41cd039cec2fe0e67437d80856f14.camel@linux.intel.com>
Date:   Tue, 26 Sep 2023 17:16:14 -0700
From:   "David E. Box" <david.e.box@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org, rajvi.jingar@...ux.intel.com
Subject: Re: [PATCH 05/11] platform/x86:intel/pmc: Move get_low_power_modes
 function

On Tue, 2023-09-26 at 18:56 +0300, Ilpo Järvinen wrote:
> On Fri, 22 Sep 2023, David E. Box wrote:
> 
> > From: Xi Pardee <xi.pardee@...el.com>
> > 
> > Some platforms will have a need to retrieve the low power modes as part of
> > their driver initialization. As such, make the function global and call it
> > from the platform specific init code.
> 
> What is the real justification for this change, I don't think it's clearly 
> stated above?

It needs to be moved from core code to platform init code so that (in patch 9)
we can get the entry requirement list for the enabled modes, which won't be
known before this function is ran. I'll update the changelog.