linux-kernel - Re: [PATCH 3/3] arm64: dts: Add gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb37e3ec-d0b9-4b73-ac6e-183b55e8814f@linux.com>
Date:   Wed, 27 Sep 2023 07:07:02 +0100
From:   Lucas Tanure <tanure@...ux.com>
To:     neil.armstrong@...aro.org, Huqiang Qin <huqiang.qin@...ogic.com>,
        tglx@...utronix.de, maz@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, hkallweit1@...il.com
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: Add gpio_intc node for Amlogic-T7 SoCs

On 14-09-2023 09:26, neil.armstrong@...aro.org wrote:
> On 13/09/2023 10:09, Huqiang Qin wrote:
>> Add GPIO interrupt controller device.
>>
>> Signed-off-by: Huqiang Qin <huqiang.qin@...ogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi 
>> b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> index dae3465bd39b..21b2436c47e2 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> @@ -155,6 +155,16 @@ watchdog@...0 {
>>                   clocks = <&xtal>;
>>               };
>> +            gpio_intc: interrupt-controller@...0 {
>> +                compatible = "amlogic,t7-gpio-intc",
>> +                         "amlogic,meson-gpio-intc";
>> +                reg = <0x0 0x4080 0x0 0x20>;
>> +                interrupt-controller;
>> +                #interrupt-cells = <2>;
>> +                amlogic,channel-interrupts =
>> +                    <10 11 12 13 14 15 16 17 18 19 20 21>;
>> +            };
>> +
>>               uart_a: serial@...00 {
>>                   compatible = "amlogic,t7-uart", 
>> "amlogic,meson-s4-uart";
>>                   reg = <0x0 0x78000 0x0 0x18>;
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
I re-tested this today with Vim4 and works fine.
By works I mean, vim4 is able to boot without panics but drops to 
emergency shell as expected.

Tested-by: Lucas Tanure <tanure@...ux.com>