linux-kernel - Re: [PATCH] eventfd: move 'eventfd-count' printing out of spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff95e764-9e61-4204-8024-42f15c34f084@kernel.dk>
Date:   Wed, 27 Sep 2023 01:32:56 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     wenyang.linux@...mail.com,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Cc:     Christoph Hellwig <hch@....de>, Dylan Yudaken <dylany@...com>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Matthew Wilcox <willy@...radead.org>,
        Eric Biggers <ebiggers@...gle.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eventfd: move 'eventfd-count' printing out of spinlock

On 9/26/23 8:05 AM, wenyang.linux@...mail.com wrote:
> From: Wen Yang <wenyang.linux@...mail.com>
> 
> It is better to print debug messages outside of the wqh.lock
> spinlock where possible.

Does it really matter for fdinfo? Your commit message is a bit
light, so I'm having to guess whether this is fixing a real issue
for you, or if it's just a drive-by observation.

-- 
Jens Axboe