linux-kernel - Re: [PATCH 1/2] arm64: dts: imx93: Add audio device nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2023 09:52:47 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Chancel Liu <chancel.liu@....com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: imx93: Add audio device nodes

On 27/09/2023 04:33, Chancel Liu wrote:
> Add audio devices nodes including SAI, MICFIL, XCVR and MQS.
> 
> Signed-off-by: Chancel Liu <chancel.liu@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 87 ++++++++++++++++++++++++
>  1 file changed, 87 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index f20dd18e0b65..6ed7b156c633 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -366,6 +366,25 @@ flexcan1: can@...a0000 {
>  				status = "disabled";
>  			};
>  
> +			sai1: sai@...b0000 {
> +				compatible = "fsl,imx93-sai";
> +				reg = <0x443b0000 0x10000>;
> +				interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clk IMX93_CLK_SAI1_IPG>, <&clk IMX93_CLK_DUMMY>,
> +					 <&clk IMX93_CLK_SAI1_GATE>, <&clk IMX93_CLK_DUMMY>,
> +					 <&clk IMX93_CLK_DUMMY>;
> +				clock-names = "bus", "mclk0", "mclk1", "mclk2", "mclk3";
> +				dmas = <&edma1 22 0 1>, <&edma1 21 0 0>;
> +				dma-names = "rx", "tx";
> +				status = "disabled";
> +			};
> +
> +			mqs1: mqs {

Why do you have non-MMIO nodes in soc@? You introduce new warnings.
Please test your code (dtbs_check W=1)


Best regards,
Krzysztof