linux-kernel - Re: [PATCH v2 4/9] platform/x86/intel/ifs: Gen2 Scan test support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Sep 2023 16:26:40 -0700
From:   "Joseph, Jithu" <jithu.joseph@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC:     Hans de Goede <hdegoede@...hat.com>, <markgross@...nel.org>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
        <rostedt@...dmis.org>, <ashok.raj@...el.com>,
        <tony.luck@...el.com>, LKML <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <patches@...ts.linux.dev>,
        <ravi.v.shankar@...el.com>, <pengfei.xu@...el.com>
Subject: Re: [PATCH v2 4/9] platform/x86/intel/ifs: Gen2 Scan test support



On 9/26/2023 3:20 AM, Ilpo Järvinen wrote:
> On Mon, 25 Sep 2023, Joseph, Jithu wrote:
>> On 9/25/2023 8:39 AM, Ilpo Järvinen wrote:
>>> On Fri, 22 Sep 2023, Jithu Joseph wrote:
>>>
>>
>> ...
>>
>>>>  
>>>> -	activate.rsvd = 0;
>>>>  	activate.delay = IFS_THREAD_WAIT;
>>>>  	activate.sigmce = 0;
>>>> -	activate.start = 0;
>>>> -	activate.stop = ifsd->valid_chunks - 1;
>>>> +	to_start = 0;
>>>> +	to_stop = ifsd->valid_chunks - 1;
>>>> +
>>>> +	if (ifsd->generation) {
>>>> +		activate.gen2.start = to_start;
>>>> +		activate.gen2.stop = to_stop;
>>>> +	} else {
>>>> +		activate.gen0.start = to_start;
>>>> +		activate.gen0.stop = to_stop;
>>>> +	}
>>>
>>> Is it okay to not do activate.gen0.rsvd = 0 anymore? If you know it is, it 
>>> would be nice to record that fact into the changelog so that it can be 
>>> found in the history.
>>
>> I did test on a gen0 to check if there is a problem due to this (and it seemed fine).
>> I will make a note in changelog as you suggest
> 
> Actually, I realized activate is a variable in stack and those bits are
> uninitilized without that assignment so don't remove it.
> 

Ok, I will post a v3 with all the suggested changes in a few days ... Thanks for the review

Jithu