linux-kernel - Re: [PATCH v2 2/3] regulator: dt-bindings: Add mps,mpq2286 power-management IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <358f7d3c-42d1-6405-0013-997deb974ce3@linumiz.com>
Date:   Wed, 27 Sep 2023 14:21:18 +0530
From:   Saravanan Sekar <saravanan@...umiz.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        krzysztof.kozlowski+dt@...aro.org
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        lgirdwood@...il.com, conor+dt@...nel.org, linux@...ck-us.net,
        linux-hwmon@...r.kernel.org, broonie@...nel.org,
        sravanhome@...il.com, robh+dt@...nel.org, jdelvare@...e.com
Subject: Re: [PATCH v2 2/3] regulator: dt-bindings: Add mps,mpq2286
 power-management IC

On 27/09/23 13:36, Krzysztof Kozlowski wrote:
> On 27/09/2023 05:39, Saravanan Sekar wrote:
>> Document mpq2286 power-management IC
>>
>> Signed-off-by: Saravanan Sekar <saravanan@...umiz.com>
>> ---
>>   .../bindings/regulator/mps,mpq2286.yaml       | 59 +++++++++++++++++++
>>   1 file changed, 59 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml
>> new file mode 100644
>> index 000000000000..594b929fe4b8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml
>> @@ -0,0 +1,59 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/regulator/mps,mpq2286.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Monolithic Power System MPQ2286 PMIC
>> +
>> +maintainers:
>> +  - Saravanan Sekar <saravanan@...umiz.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - mps,mpq2286
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  regulators:
>> +    type: object
>> +
>> +    properties:
>> +      buck0:
> 
> If you have just one buck, it should be "buck".
> 

As replied in v1 review comments, other chipset has multiple regulator 
so buck0 used to keep the driver common

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
> 

Thanks,
Saravanan