linux-kernel - Re: [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef69122bc6aa64bd8df6c5a2d0ec6d82380d5560.camel@iokpp.de>
Date:   Wed, 27 Sep 2023 10:56:36 +0200
From:   Bean Huo <beanhuo@...pp.de>
To:     Francesco Dolcini <francesco@...cini.it>
Cc:     ulf.hansson@...aro.org, adrian.hunter@...el.com,
        beanhuo@...ron.com, jakub.kwapisz@...adex.com,
        rafael.beims@...adex.com, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for
 Micron eMMC Q2J54A

On Fri, 2023-09-22 at 19:01 +0200, Francesco Dolcini wrote:
> > +
> > +                       if (host->card->quirks &
> > MMC_QUIRK_BROKEN_CACHE_FLUSH &&
> > +                           !host->card->written_flag && !ret)
> > +                               host->card->written_flag = true;
> 
> From what I can see this branch is followed for both REQ_OP_READ and
> REQ_OP_WRITE, and I would say we want to set this flag only for
> REQ_OP_WRITE.
> 
> Am I wrong?
> 
> Francesco

you are right, we only care about write, I will update it in the next
version, thanks for your review!

Kind regards,
Bean