linux-kernel - Re: [net-next PATCH] net: sfp: add quirk for Fiberstone GPON-ONU-34-20BI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRP7FU3BglzFBfgX@shell.armlinux.org.uk>
Date:   Wed, 27 Sep 2023 10:51:17 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Christian Marangi <ansuelsmth@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH] net: sfp: add quirk for Fiberstone
 GPON-ONU-34-20BI

On Thu, Sep 21, 2023 at 04:40:45PM +0200, Paolo Abeni wrote:
> Hi Russel,
> 
> On Tue, 2023-09-19 at 14:40 +0100, Russell King (Oracle) wrote:
> > On Tue, Sep 19, 2023 at 02:47:20PM +0200, Christian Marangi wrote:
> > > Fiberstone GPON-ONU-34-20B can operate at 2500base-X, but report 1.2GBd
> > > NRZ in their EEPROM.
> > > 
> > > The module also require the ignore tx fault fixup similar to Huawei MA5671A
> > > as it gets disabled on error messages with serial redirection enabled.
> > 
> > I'll send you shortly a different approach for the "ignore tx fault"
> > thing that I'd like you to test please.
> 
> Said patch is not blocking this one, am I correct?

Correct, but Christian has not responded in any way despite me sending
him the patch that I'd like tested, which is very disappointing.

This is what I fear - that merging his patch removes the incentive to
test my patch. Oh well, I guess I will just send my patch that I can't
test to be merged anyway, and to hell with it. If it breaks this and
other modules, I'm sure someone will eventually send a report about
that.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!