[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <TYWPR01MB8775B9F9F70CA75410788F83C2C2A@TYWPR01MB8775.jpnprd01.prod.outlook.com>
Date: Wed, 27 Sep 2023 10:18:57 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Mark Brown <broonie@...nel.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>
CC: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Magnus Damm <magnus.damm@...il.com>,
"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>,
Chris Paterson <Chris.Paterson2@...esas.com>,
Biju Das <biju.das@...renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related
properties
Hi Mark,
Thanks for your reply!
> From: Mark Brown <broonie@...nel.org>
> Subject: Re: [PATCH 1/2] spi: renesas,rzv2m-csi: Add SPI Slave related
> properties
>
> On Wed, Sep 27, 2023 at 11:44:17AM +0200, Geert Uytterhoeven wrote:
> > On Wed, Sep 27, 2023 at 11:21 AM Mark Brown <broonie@...nel.org>
> wrote:
>
> > > I see. Is there any control over what the chip select is when
> there is
> > > one, in which case we could just look to see if there's one
> specified?
>
> > On RZ/V2M there isn't, as there is only a single hardware chip
> select.
>
> > On MSIOF, there are 3 hardware chip selects, but apparently only the
> > primary one can be used in target mode.
>
> OK, it sounds like we do need a property then. Like I say I'd rather
> not have one that just works for _NO_CS in order to avoid confusion
> for
> people writing SPI device drivers, either something in the generic
> target binding or a device specific one.
Shall I invert the logic then? What I mean is I could drop property
"renesas,csi-ss" and add property "renesas,csi-no-ss" instead, therefore
without "renesas,csi-no-ss" pin SS will be used, with "renesas,csi-no-ss"
pin SS won't be used.
What do you think?
Also, I could drop "renesas,csi-ss-high" and use "spi-cs-high" instead?
Geert, any thoughts on the above?
Thanks,
Fab
Powered by blists - more mailing lists