[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230927101948.GA27975@linuxcarl2.richtek.com>
Date: Wed, 27 Sep 2023 18:19:48 +0800
From: ChiYuan Huang <cy_huang@...htek.com>
To: Mark Brown <broonie@...nel.org>
CC: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
Allen Lin <allen_lin@...htek.com>,
<alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: codecs: rtq9128: Add TDM data source selection
On Wed, Sep 27, 2023 at 11:59:31AM +0200, Mark Brown wrote:
> On Wed, Sep 27, 2023 at 05:46:37PM +0800, ChiYuan Huang wrote:
> > On Wed, Sep 27, 2023 at 11:13:22AM +0200, Mark Brown wrote:
>
> > > Is this something that's going to be changing dynamically at runtime or
> > > should this be a device property that's set either by firmware or when
> > > we're doing the TDM setup? This sounds like something I'd expect to be
> > > fixed by the board design.
>
> > I may think one case if ASoC platform support multiple data source outputs
> > that share the same bck/lcrk on different data pin. If it can be dynamically
> > adjusted for the scenarios, this will keep the flexibility for the differet
> > platform design.
>
> Sure, but is that actually a practical design - or if someone is doing
> this shouldn't it be joined up with the TDM configuration since with
> just the control it'd only be possible to switch the pins but not change
> the TDM layout? I'm not sure that this control works as a standalone
> thing.
I think if two data source input for different scenarios, then the data source
switch will become practical. For the standalone usage, keep a device property
to decide this may be enough. But consider the future application, to keep this
in general mixer control is still usable to meet the complex design.
Powered by blists - more mailing lists