linux-kernel - Re: [PATCH] media: pci: intel: ivsc: select V4L2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRQGpg/jX25Wgm8z@kekkonen.localdomain>
Date:   Wed, 27 Sep 2023 10:40:38 +0000
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Wentong Wu <wentong.wu@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: pci: intel: ivsc: select V4L2_FWNODE

Hi Arnd,

On Wed, Sep 27, 2023 at 09:21:19AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Some missing select statements were already added back, but I ran into
> another one that is missing:
> 
> ERROR: modpost: "v4l2_fwnode_endpoint_free" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> ERROR: modpost: "v4l2_fwnode_endpoint_alloc_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> ERROR: modpost: "v4l2_fwnode_endpoint_parse" [drivers/media/pci/intel/ivsc/ivsc-csi.ko] undefined!
> 
> Fixes: 29006e196a566 ("media: pci: intel: ivsc: Add CSI submodule")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/media/pci/intel/ivsc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
> index 0acea4678fc0d..6a2995b02d274 100644
> --- a/drivers/media/pci/intel/ivsc/Kconfig
> +++ b/drivers/media/pci/intel/ivsc/Kconfig
> @@ -7,6 +7,7 @@ config INTEL_VSC
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select V4L2_ASYNC
> +	select V4L2_FWNODE

Thanks for the fix.

V4L2_FWNODE already implies V4L2_ASYNC so V4L2_ASYNC can be removed. I
somehow thought this only needed V4L2_ASYNC but that indeed is not the
case.

I'll just drop the line selecting V4L2_ASYNC above if that's fine.

>  	help
>  	  This adds support for Intel Visual Sensing Controller (IVSC).
>  

-- 
Regards,

Sakari Ailus