[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <31585f93157c5c4487b53e3bcb6aac9e92e62f92.camel@linux.ibm.com>
Date: Wed, 27 Sep 2023 06:52:26 -0400
From: Mimi Zohar <zohar@...ux.ibm.com>
To: Arnd Bergmann <arnd@...nel.org>,
Dmitry Kasatkin <dmitry.kasatkin@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, Paul Moore <paul@...l-moore.com>,
James Morris <jmorris@...ei.org>,
"Serge E. Hallyn" <serge@...lyn.com>,
Jarkko Sakkinen <jarkko@...nel.org>,
Nayna Jain <nayna@...ux.ibm.com>,
Eric Snowberg <eric.snowberg@...cle.com>,
Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
Randy Dunlap <rdunlap@...radead.org>,
Oleksandr Tymoshenko <ovt@...gle.com>,
linux-integrity@...r.kernel.org,
linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ima: rework CONFIG_IMA dependency block
On Wed, 2023-09-27 at 09:22 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Changing the direct dependencies of IMA_BLACKLIST_KEYRING and
> IMA_LOAD_X509 caused them to no longer depend on IMA, but a
> a configuration without IMA results in link failures:
>
> arm-linux-gnueabi-ld: security/integrity/iint.o: in function `integrity_load_keys':
> iint.c:(.init.text+0xd8): undefined reference to `ima_load_x509'
>
> aarch64-linux-ld: security/integrity/digsig_asymmetric.o: in function `asymmetric_verify':
> digsig_asymmetric.c:(.text+0x104): undefined reference to `ima_blacklist_keyring'
>
> Adding explicit dependencies on IMA would fix this, but a more reliable
> way to do this is to enclose the entire Kconfig file in an 'if IMA' block.
> This also allows removing the existing direct dependencies.
>
> Fixes: be210c6d3597f ("ima: Finish deprecation of IMA_TRUSTED_KEYRING Kconfig")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Oleksandr Tymoshenko's patch to address this, made it into linux-next
today.
Commit be210c6d3597 ("ima: Finish deprecation of IMA_TRUSTED_KEYRING
Kconfig") made it last night into linux-next.
--
thanks,
Mimi
Powered by blists - more mailing lists