linux-kernel - Re: [External] : [PATH v3] cgroup: add cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c77e132a-da4b-a6e3-38d4-7ce00916eb28@oracle.com>
Date:   Wed, 27 Sep 2023 16:40:50 +0530
From:   Kamalesh Babulal <kamalesh.babulal@...cle.com>
To:     Luiz Capitulino <luizcap@...zon.com>, tj@...nel.org,
        lizefan.x@...edance.com, hannes@...xchg.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        longman@...hat.com, mkoutny@...e.com
Cc:     lcapitulino@...il.com
Subject: Re: [External] : [PATH v3] cgroup: add cgroup_favordynmods=
 command-line option



On 9/27/23 02:46, Luiz Capitulino wrote:
> We have a need of using favordynmods with cgroup v1, which doesn't support
> changing mount flags during remount. Enabling CONFIG_CGROUP_FAVOR_DYNMODS at
> build-time is not an option because we want to be able to selectively
> enable it for certain systems.
> 
> This commit addresses this by introducing the cgroup_favordynmods=
> command-line option. This option works for both cgroup v1 and v2 and also
> allows for disabling favorynmods when the kernel built with
> CONFIG_CGROUP_FAVOR_DYNMODS=y.
> 
> Also, note that when cgroup_favordynmods=true favordynmods is never
> disabled in cgroup_destroy_root().
> 
> Signed-off-by: Luiz Capitulino <luizcap@...zon.com>

The patch looks good to me, I have also boot tested it with combinations of
CONFIG_CGROUP_FAVOR_DYNMODS={y, n}, while passing the kernel parameter
cgroup_favordynmods={true, false} to the command line and works as expected.

Reviewed-by: Kamalesh Babulal <kamalesh.babulal@...cle.com>