linux-kernel - Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qvqw5y3w30w4.fsf@devbig1114.prn1.facebook.com>
Date:   Tue, 26 Sep 2023 17:39:09 -0700
From:   Stefan Roesch <shr@...kernel.io>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     David Hildenbrand <david@...hat.com>, kernel-team@...com,
        hannes@...xchg.org, riel@...riel.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode


Andrew Morton <akpm@...ux-foundation.org> writes:

> On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch <shr@...kernel.io> wrote:
>
>> > Thinking about it, what are the cons of just enabling this always and not
>> > exposing new toggles? Alternatively, we could make this a compile-time option.
>> >
>> > In general, LGTM, just curious if we really have to make this configurable.
>> >
>>
>> The only downside I can see is that it might take a longer time for some
>> pages to be de-duplicated (a new candidate page is added, but its
>> duplicate is skipped in this round). So it will take longer to
>> de-duplicate this page.
>>
>> I tested with more than one workload, but it might be useful to get some
>> data with additional workloads. I was thinking of enabling it after one or
>> two releases.
>
> We could keep the tunable and make it default "on"?

Sounds good to me