linux-kernel - Re: [PATCH RFC v2 5/6] ARM: pxa: Convert Spitz hsync to GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2023 14:54:32 +0200
From:   Duje Mihanović <duje.mihanovic@...le.hr>
To:     Andy Shevchenko <andy@...nel.org>
Cc:     Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Russell King <linux@...linux.org.uk>,
        Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH RFC v2 5/6] ARM: pxa: Convert Spitz hsync to GPIO descriptors

On Tuesday, September 26, 2023 6:19:23 PM CEST Andy Shevchenko wrote:
> On Tue, Sep 26, 2023 at 05:46:26PM +0200, Duje Mihanović wrote:
> >  	gpiod_add_lookup_table(&spitz_ads7846_gpio_table);
> >  	gpiod_add_lookup_table(&spitz_spi_gpio_table);
> > 
> > +	hsync = gpiod_get(NULL, "hsync", GPIOD_IN);
> > +	if (IS_ERR(hsync)) {
> > +		pr_err("Failed to get hsync GPIO: %ld\n", PTR_ERR(hsync));
> > +		return;
> > +	}
> > 
> >  	pxa2xx_set_spi_info(2, &spitz_spi_info);
> >  	spi_register_board_info(ARRAY_AND_SIZE(spitz_spi_devices));
> 
> Yeah, but the question is, if GPIO request fails, can we instantiate at 
least one device and move on?

I see. If the touchscreen is the first out of 3 devices in that array, would 
something like this do:

spi_register_board_info(ARRAY_AND_SIZE(&spitz_spi_devices[1]));

Regards,
Duje