lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c442a175-f04f-44ea-b7ee-a6de81963f4c@kadam.mountain>
Date:   Wed, 27 Sep 2023 16:12:50 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     wangweidong.a@...nic.com
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        perex@...ex.cz, tiwai@...e.com, shumingf@...ltek.com,
        rf@...nsource.cirrus.com, herve.codina@...tlin.com, arnd@...db.de,
        13916275206@....com, ryans.lee@...log.com,
        linus.walleij@...aro.org, ckeepax@...nsource.cirrus.com,
        doug@...morgal.com, fido_max@...ox.ru,
        harshit.m.mogalapalli@...cle.com, liweilei@...nic.com,
        yang.lee@...ux.alibaba.com, u.kleine-koenig@...gutronix.de,
        yijiangtao@...nic.com, colin.i.king@...il.com, trix@...hat.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 3/8] ASoC: codecs: Modify the code related to the
 property

On Wed, Sep 27, 2023 at 08:16:29PM +0800, wangweidong.a@...nic.com wrote:
> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> Remove the "fade-enable" property because other properties
> already implement this functionality.
> Rename "sound-channel" to "awinic,audio-channel",
> this is to be consistent with the "awinic,aw88395.yaml" file

This feels like it should be split into two patches.

patch 4/9: remove the "fade-enable property".
Btw, which other properties implement this.  Can you add that to the
commit message?

patch 5/9: Rename "sound-channel" to "awinic,audio-channel".

regards,
dan carpenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ