linux-kernel - Re: [RFC PATCH] nfs: reduce stack usage of nfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BAF96CD3-98A1-4D61-B188-BBCFBE81EA22@redhat.com>
Date:   Wed, 27 Sep 2023 09:45:25 -0400
From:   Benjamin Coddington <bcodding@...hat.com>
To:     Nicholas Piggin <npiggin@...il.com>
Cc:     linux-nfs@...r.kernel.org,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] nfs: reduce stack usage of nfs_get_root

On 26 Sep 2023, at 20:16, Nicholas Piggin wrote:

> Move fsinfo allocation off stack, reducing stack overhead of
> nfs_get_root from 304 to 192 bytes.
>
> Signed-off-by: Nicholas Piggin <npiggin@...il.com>
> ---
> Hi,
>
> This is motivated by a stack overflow described here:
> https://lore.kernel.org/netdev/20230927001308.749910-1-npiggin@gmail.com/
>
> NFS is not really a major culprit but it seems not too hard to
> shrink the stack a little.
>
> Thanks,
> Nick

Looks good, might be able to get rid of the local "root" var too if the
compiler doesn't optimize it away.

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben