linux-kernel - Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230927102818.27b0beff6006392e91380ecd@hugovil.com>
Date:   Wed, 27 Sep 2023 10:28:18 -0400
From:   Hugo Villeneuve <hugo@...ovil.com>
To:     Rob Herring <robh@...nel.org>
Cc:     gregkh@...uxfoundation.org, jirislaby@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        hvilleneuve@...onoff.com, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to
 irda-mode-ports property

On Fri, 22 Sep 2023 14:52:06 -0500
Rob Herring <robh@...nel.org> wrote:

> On Thu, Sep 21, 2023 at 11:32 AM Hugo Villeneuve <hugo@...ovil.com> wrote:
> >
> > On Thu, 21 Sep 2023 11:24:24 -0500
> > Rob Herring <robh@...nel.org> wrote:
> >
> > > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote:
> > > > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > > >
> > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor
> > > > prefix. Add "nxp," prefix to comply with DT best practises.
> > >
> > > The opposite direction would be worth carrying in the driver, but I
> > > don't think adding a vendor prefix is. I would just leave this as-is.
> > >
> > > Rob
> >
> > Hi Rob,
> > I am not following you, can you clarify?
> 
> Just keep the property as-is and don't add a 'nxp,' prefixed version.
> It's not worth carrying the fallback in the driver.
> 
> If you were dropping a vendor prefix from a property, then that's
> worth it because there might be other users added.
> 
> Rob

Hi Rob,
ok, then I will drop this patch as well as the other titled
'serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property' for
V2.

Hugo.