linux-kernel - Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration by adding identifier name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Sep 2023 20:08:13 +0530
From:   Bragatheswaran Manickavel <bragathemanick0908@...il.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, rafael@...nel.org,
        rui.zhang@...el.com, amitk@...nel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com
Cc:     linux-imx@....com, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: imx8mm_thermal: Fix function pointer declaration
 by adding identifier name


On 25/09/23 13:17, Daniel Lezcano wrote:
> On 22/09/2023 11:31, Bragatheswaran Manickavel wrote:
>>
>> On 17/09/23 14:04, Bragatheswaran Manickavel wrote:
>>> Added identifier names to respective definitions for fix
>>> warnings reported by checkpatch.pl
>>>
>>> WARNING: function definition argument 'void *' should also have an 
>>> identifier name
>>> WARNING: function definition argument 'int *' should also have an 
>>> identifier name
>>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@...il.com>
>>> ---
>>>   drivers/thermal/imx8mm_thermal.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/thermal/imx8mm_thermal.c 
>>> b/drivers/thermal/imx8mm_thermal.c
>>> index 14111ccf6e4c..5dc6c18f12df 100644
>>> --- a/drivers/thermal/imx8mm_thermal.c
>>> +++ b/drivers/thermal/imx8mm_thermal.c
>>> @@ -78,7 +78,7 @@
>>>   struct thermal_soc_data {
>>>       u32 num_sensors;
>>>       u32 version;
>>> -    int (*get_temp)(void *, int *);
>>> +    int (*get_temp)(void *data, int *temp);
>>>   };
>>>   struct tmu_sensor {
>>
>> Hi Team, Could someone help in reviewing it.
>
> Please no more "gentle reminder"
>
> Read:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/tree/Documentation/process/submitting-patches.rst 
>
>
> Especially, the section _9_
>
> Thanks
>
>    -- Daniel
>

Hi Daniel,

Understood. Will wait for this to get reviewed.

Thanks,
Bragathe