[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM4PR12MB6445548E05C8E3B29AAEAFCAEEC1A@DM4PR12MB6445.namprd12.prod.outlook.com>
Date: Thu, 28 Sep 2023 14:30:47 +0000
From: "Joshi, Mukul" <Mukul.Joshi@....com>
To: "Yadav, Arvind" <Arvind.Yadav@....com>,
"Koenig, Christian" <Christian.Koenig@....com>,
"Deucher, Alexander" <Alexander.Deucher@....com>,
"Sharma, Shashank" <Shashank.Sharma@....com>,
"Kuehling, Felix" <Felix.Kuehling@....com>,
"Pan, Xinhui" <Xinhui.Pan@....com>,
"airlied@...il.com" <airlied@...il.com>,
"daniel@...ll.ch" <daniel@...ll.ch>
CC: "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Koenig, Christian" <Christian.Koenig@....com>
Subject: RE: [PATCH v2 1/1] drm/amdkfd: Fix unaligned doorbell absolute offset
for gfx8
[AMD Official Use Only - General]
> -----Original Message-----
> From: Yadav, Arvind <Arvind.Yadav@....com>
> Sent: Thursday, September 28, 2023 5:54 AM
> To: Koenig, Christian <Christian.Koenig@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; Sharma, Shashank
> <Shashank.Sharma@....com>; Kuehling, Felix <Felix.Kuehling@....com>;
> Joshi, Mukul <Mukul.Joshi@....com>; Pan, Xinhui <Xinhui.Pan@....com>;
> airlied@...il.com; daniel@...ll.ch
> Cc: amd-gfx@...ts.freedesktop.org; dri-devel@...ts.freedesktop.org; linux-
> kernel@...r.kernel.org; Yadav, Arvind <Arvind.Yadav@....com>; Koenig,
> Christian <Christian.Koenig@....com>
> Subject: [PATCH v2 1/1] drm/amdkfd: Fix unaligned doorbell absolute offset
> for gfx8
>
> This patch is to adjust the absolute doorbell offset against the doorbell id
> considering the doorbell size of 32/64 bit.
>
> v2:
> - Addressed the review comment from Felix.
>
> Cc: Christian Koenig <christian.koenig@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Signed-off-by: Shashank Sharma <shashank.sharma@....com>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@....com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 0d3d538b64eb..c54c4392d26e 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -407,7 +407,14 @@ static int allocate_doorbell(struct
> qcm_process_device *qpd,
>
> q->properties.doorbell_off = amdgpu_doorbell_index_on_bar(dev-
> >adev,
> qpd-
> >proc_doorbells,
> - q-
> >doorbell_id);
> + 0);
> +
It looks like amdgpu_doorbell_index_on_bar() works only for 64-bit doorbells.
Shouldn't it work for both 32-bit and 64-bit doorbells considering this is common
doorbell manager code?
Thanks,
Mukul
> + /* Adjust the absolute doorbell offset against the doorbell id
> considering
> + * the doorbell size of 32/64 bit.
> + */
> + q->properties.doorbell_off += q->doorbell_id *
> + dev->kfd->device_info.doorbell_size / 4;
> +
> return 0;
> }
>
> --
> 2.34.1
Powered by blists - more mailing lists